Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# Renderer with --features just-types doesn't include required usings. #2523

Open
gregmarr opened this issue Feb 27, 2024 · 0 comments
Open
Labels
bug C# C# Output good first issue Not necessarily easy, but doesn't require deep quicktype knowledge rendering

Comments

@gregmarr
Copy link

gregmarr commented Feb 27, 2024

If you run the C# renderer with --features just-types --array-type list then it creates List<T> properties, but doesn't add the required using System.Collections.Generic;. It also happens without the --array-type list if a Dictionary<K,V> is generated as a property.

This is due to the checks here, with FIXMEs from 6 years ago pointing out this exact bug.

// FIXME: We need System.Collections.Generic whenever we have maps or use List.

// FIXME: We need System.Collections.Generic whenever we have maps or use List.

@inferrinizzard inferrinizzard added bug C# C# Output rendering good first issue Not necessarily easy, but doesn't require deep quicktype knowledge labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug C# C# Output good first issue Not necessarily easy, but doesn't require deep quicktype knowledge rendering
Projects
None yet
Development

No branches or pull requests

2 participants