Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guzzle_logger v2.2.0 incompatible with Guzzle >= 7.7.0 #48

Open
mwolff-fn opened this issue Jun 16, 2023 · 4 comments
Open

guzzle_logger v2.2.0 incompatible with Guzzle >= 7.7.0 #48

mwolff-fn opened this issue Jun 16, 2023 · 4 comments

Comments

@mwolff-fn
Copy link

Using Guzzle 7.7.0 and gmponos/guzzle_logger 2.2.0, we recently ran into this error:

Error: Call to undefined function GuzzleHttp\Promise\rejection_for()

/project/vendor/gmponos/guzzle_logger/src/LogMiddleware.php:115
/project/vendor/guzzlehttp/promises/src/Promise.php:209
/project/vendor/guzzlehttp/promises/src/Promise.php:158
/project/vendor/guzzlehttp/promises/src/TaskQueue.php:52
/project/vendor/guzzlehttp/promises/src/Promise.php:251
/project/vendor/guzzlehttp/promises/src/Promise.php:227
/project/vendor/guzzlehttp/promises/src/Promise.php:272
/project/vendor/guzzlehttp/promises/src/Promise.php:229
/project/vendor/guzzlehttp/promises/src/Promise.php:69
/project/vendor/guzzlehttp/guzzle/src/Client.php:189
/project/vendor/guzzlehttp/guzzle/src/ClientTrait.php:44

I suspect it might have to do with Guzzle 7.7.0 now supporting guzzlehttp/promises v2, which removes all functions in favour of static methods (https://github.com/guzzle/promises/blob/2.0.0/CHANGELOG.md).

@SvenRtbg
Copy link

Alternatively make this library depend on guzzlehttp/promises ^1.5 explicitly, that will prevent installing the newer library with the removed functions.

mwolff-fn added a commit to mwolff-fn/guzzle-log-middleware that referenced this issue Aug 2, 2023
mwolff-fn added a commit to mwolff-fn/guzzle-log-middleware that referenced this issue Aug 2, 2023
@mwolff-fn
Copy link
Author

I created a PR to fix the issue: #50

@EmanSalla
Copy link

We need this PR to be merged #50

@ossycodes
Copy link

ossycodes commented Aug 21, 2023

@gmponos we still waiting for this to be merged #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants