add job storage #607
Closed
add job storage #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Nov 14, 2023
| "github.com/google/uuid" | ||
| ) | ||
|
|
||
| type JobObject struct { |
There was a problem hiding this comment.
what about the actual job function? Right now, only the job run information is stored and not the actual function to be run 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
It allows the scheduler to load jobs from a job object, which may come from persistent storage.
And it reports job run results to a reporter interface, which can be helpful for job resuming.
Which issue(s) does this PR fix/relate to?
Resolves #533
List any changes that modify/break current functionality
No break changes.
Have you included tests for your changes?
Yes.
TestLoadJobFromObjectinscheduler_test.goTest_ExecutorJobReportinexecutor_test.goDid you document any new/modified functionality?
example_test.goREADME.mdNotes