Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs should ignore merge commits #30760

Open
TheFriendlyCoder opened this issue Apr 29, 2024 · 0 comments
Open

PRs should ignore merge commits #30760

TheFriendlyCoder opened this issue Apr 29, 2024 · 0 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@TheFriendlyCoder
Copy link

Feature Description

When a new PR gets created and the source branch matches the commit history of the target branch exactly with the exception of a merge commit, the web UI warns you the the source branch is out of date. While this is, strictly speaking, accurate, merge commits don’t actually contain any source code changes and so this warning can be ignored. However, if there are actual code commits on the target branch then it may not be safe to ignore this warning. Without doing a full comparison between the branches it is impossible to know for sure. This creates unnecessary confusion for users.

I am pretty sure other git repository tools like GitHub and Gitlab exclude merge commits when doing history comparisons to avoid this problem.

This issue is particularly problematic for developers that regularly stack commits across multiple PRs because every PR after the first will inherit this branch out of date warning

Screenshots

No response

@TheFriendlyCoder TheFriendlyCoder added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

1 participant