Using go-rod with firefox, failing to start new instance of firefox #1060
Comments
|
The following code uses // From https://gist.github.com/lee8oi/ec404fa99ea0f6efd9d1
func Start(args ...string) (p *os.Process, err error) {
if args[0], err = exec.LookPath(args[0]); err == nil {
var procAttr os.ProcAttr
procAttr.Files = []*os.File{os.Stdin,
os.Stdout, os.Stderr}
p, err := os.StartProcess(args[0], args, &procAttr)
if err == nil {
return p, nil
}
}
return nil, err
}
func startFirefox2() {
p, err := Start("firefox", "--profile", "/home/.../Data/nz5ijj7z.profile", "--new-instance")
if err != nil {
panic(err)
}
p.Wait()
}Trying to start firefox with go-rod and |
|
I finally identified the cause. Firefox ignores the argument This is a limitation of firefox with the The following code does nearly everything like go-rod except that the profile parameter is properly separated. It then works and port 9333 is opened. func Start(bin string, args ...string) (p *os.Process, err error) {
cmd := exec.Command(bin, args...)
cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
cmd.Stdout = io.MultiWriter(io.Discard, launcher.NewURLParser())
cmd.Stderr = io.MultiWriter(io.Discard, launcher.NewURLParser())
err = cmd.Start()
if err != nil {
return
}
return cmd.Process, err
}
func startFirefox2() {
p, err := Start("/usr/bin/firefox", "--new-instance", "--profile", profileDir, "--remote-debugging-port=9333")
if err != nil {
panic(err)
}
p.Wait()
}I don’t know if there can be a quick fix to use go-rod with firefox. As I can’t test the code beyond that I don’t know. |
|
So apparently, firefox is not supported by go-rod because of another problem. Sorry to hear that. |
|
I’m in the process to fix the firefox command line limitation myself so that it will support "--option=param" arguments as needed for go-rod. The code fix is written and going through the review process. |
Rod Version: v0.116.0
I’m desperately trying to start a new instance of firefox with go-rod while another one is running.
I keep getting the error message that firefox is running and launching firefox fails.
The code to demonstrate your question
What you got
The program fails at MustLaunch by claiming that firefox is already running. I do indeed have a running instance of firefox. I want to start a new instance with the given profile which I created manually.
When I execute the command in the bash shell, it works.
This is the output I get
A new instance of firefox is thus started without problem manually.
What have you tried to solve the question
I tried to start a new instance of firefox myself with the following code and it succeeds.
Thus go-rod is doing something that prohibits firefox to start.
Maybe my
startFirefox()function is different from what go-doc is doing. I saw for instance that input and output pipes are redirected.The text was updated successfully, but these errors were encountered: