Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDExtension Bindings libraries built with SCons and CMake differ when built with MSVC #1459

Open
MartinStimpfl opened this issue May 8, 2024 · 0 comments

Comments

@MartinStimpfl
Copy link

Godot version

N/A

godot-cpp version

4.2.2 stable

System information

Windows 10

Issue description

Building the Godot-cpp Bindings via the provided SCons and CMake setups in Windows with MSVC result in .libs with different configurations or at least built with different compiler flags. The SCons version seems to always have the /MT flag set (for release and debug builds) and the CMake version the /MD flag for release builds and the /MDd flag for debug builds.
This results in compile errors like
libgodot-cpp.windows.template_debug.x86_64.lib(error_macros.windows.template_debug.x86_64.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MDd_DynamicDebug' in gdexample.obj
when linking the bindings library built with SCons in debug with a GDExtension project that has not /MT explicitly set.
Since in the CMake file /MD and /MDd are explicitly set for release and debug builds respecivly, I assume this behaviour was not intended.

Other compilers or OSs were not tested regarding this issue.

Steps to reproduce

Follow the instructions to get and build the Godot-Bindings and the GDExtension example from the C++ tutorial.
When both the bindings and the example are built with SCons it compiles without problem.

When using a CMakeLists.txt in the root directory like

cmake_minimum_required(VERSION 3.18)

set(CMAKE_CXX_STANDARD 17)

project(GDExample)

add_library(gdexample SHARED
    src/gdexample.cpp
    src/register_types.cpp
)

target_include_directories(gdexample PUBLIC
    ${CMAKE_SOURCE_DIR}/godot-cpp/gdextension
    ${CMAKE_SOURCE_DIR}/godot-cpp/include
    ${CMAKE_SOURCE_DIR}/godot-cpp/gen/include
)

target_compile_options(gdexample PUBLIC
    # /MD
    # /MT
)

target_link_libraries(gdexample
    # ${CMAKE_SOURCE_DIR}/godot-cpp/bin/godot-cpp.windows.debug.64.lib
    ${CMAKE_SOURCE_DIR}/godot-cpp/bin/libgodot-cpp.windows.template_debug.x86_64.lib
)

to build the example with, compile errors like the one shown above should appear. Also when using /MD, /MDd or /MTd flags.
When commenting in the /MT compiler flag, the errors are gone.

When building the binding with CMake (debug build; as per example in the CMakeLists.txt in the bindings repository)

cd godot-cpp
mkdir build
cd build
cmake build ..
cmake --build .

and linking the resulting library with the GDExtension example (e.g. commenting out the SCons-.lib and commenting in the CMake-.lib in my CMakeLists.txt example) the errors appear only if the /MT or /MTd flags are set.

This should show, that the bindings library configuration differs between the provided SCons and the CMake setups.

Minimal reproduction project

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant