Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n issue with footer text #497

Closed
timothyqiu opened this issue Dec 18, 2022 · 4 comments
Closed

i18n issue with footer text #497

timothyqiu opened this issue Dec 18, 2022 · 4 comments
Labels
discussion enhancement topic:content Issues and PRs related to static content

Comments

@timothyqiu
Copy link
Member

timothyqiu commented Dec 18, 2022

{{ TR('Godot is a member of the') }} <a href="https://sfconservancy.org/" target_="_blank" rel="noopener">Software Freedom Conservancy</a>.<br>
{{ TR('Kindly hosted by') }} <a href="https://tuxfamily.org" target="_blank" rel="noopener">TuxFamily.org</a>.<br>

This creates these two entries in the POT:

  • Godot is a member of the
  • Kindly hosted by

There are two issues:

  1. The order of words is fixed:
    e.g. "Godot is a member of the X" will be something like "Godot is X's member" when localized in Chinese.
  2. The period at the end of the sentence can't be localized.
    e.g. Chinese & Japanese uses instead of .

It'll be great if this part can use some placeholders like in the engine code, e.g. TR("Godot is a member of the %s.").

p.s. The sentence above also have this issue, the words are broken apart:

© 2007-{{ "now"|date("Y") }} Juan Linietsky, Ariel Manzur {{ TR('and') }} <a href="https://github.com/godotengine/godot/blob/master/AUTHORS.md" target="_blank" rel="noopener">{{ TR('contributors') }}</a>.<br>

@YuriSizov
Copy link
Contributor

YuriSizov commented Dec 18, 2022

Yep, this is known, but we've decided to do it this way for now. We will have to replace this, and maybe some others, with proper strings with placeholders at some point.

@Bholanath8436
Copy link

I want to work on this issue, please assign me this issue.

@YuriSizov
Copy link
Contributor

@Bholanath8436 Sorry, there is nothing to work on here at the moment. We don't have a decided upon solution for these cases yet.

@YuriSizov YuriSizov added enhancement discussion topic:content Issues and PRs related to static content labels Jan 16, 2023
@coppolaemilio
Copy link
Member

I'm closing this one since it refers to the previous CMS and not the current static site. Hope we can bring back i18n soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement topic:content Issues and PRs related to static content
Projects
None yet
Development

No branches or pull requests

4 participants