Editor never releases focus when "Save on focus loss" is active (DisplayServer regression)

[jgillich]

Godot version

b36447f

System information

Fedora Silverblue 36, Ryzen 2400G

Issue description

When "Save on focus loss" is active, editor instantly grabs focus through the save popup when switching to another application.

2022-06-10.07-43-51.mp4

Steps to reproduce

See above

Minimal reproduction project

No response

[Calinou]

Can you reproduce this after enabling Single Window Mode in the Editor Settings then restarting the editor?

[jgillich]

@Calinou I can not

[Rindbee]

It should be the popup of the save progress bar that made the editor regain focus.

[akien-mga]

I don't reproduce the issue anymore on 4.0 RC 3, it might have been fixed by #72439? @bruvzg

On the other hand each time there's a focus loss, these errors are printed:

ERROR: Parent node is busy setting up children, `add_child()` failed. Consider using `add_child.call_deferred(child)` instead.
   at: add_child (scene/main/node.cpp:1136)
ERROR: Condition "!is_inside_tree()" is true.
   at: popup_centered (scene/main/window.cpp:1456)

I wonder if #73365 would fix that one too.

Edit: Opened #73765 for that bug.

[jgillich]

Seems like the saving dialog doesn't appear anymore when auto-saving, not sure if #72439 did that. But the problem's resolved.

[Aeranuth]

Any progress on this bug? Still happening in 4.2. it always froze the editor if you create a new scene and lose focus. Once it pops the save window and you save the new scene, you cannot perform any action anymore.

It can be solved by enabling single window mode as mentioned above.

[Calinou]

Still happening in 4.2. it always froze the editor if you create a new scene and lose focus. Once it pops the save window and you save the new scene, you cannot perform any action anymore.

This should be fixable by making Save on Focus Loss not save scenes that haven't been saved yet (and therefore require going through the same workflow as a "save as" operation).