Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Notation docs in sign-images.md #541

Merged
merged 2 commits into from
May 27, 2024
Merged

Updated Notation docs in sign-images.md #541

merged 2 commits into from
May 27, 2024

Conversation

Roseline-Bassey
Copy link
Contributor

This PR includes an update to the existing Notation docs section in "Sign Artifacts with Cosign or Notation".
The update demonstrates how to configure an HTTPS domain for secure image signing and verification with the Notation CLI.

It fixes #540

@Roseline-Bassey
Improve the existing Notation documentation in Sign Artifacts with Co…
99b644e 
…sign or Notation to demonstrate how to configure HTTPS domain for secure image signing and verification using the Notation CLI

Signed-off-by: Roseline <roselynbassey23@gmail.com>
@Roseline-Bassey Roseline-Bassey requested review from a team as code owners January 31, 2024 15:55
FeynmanZhou
FeynmanZhou suggested changes Feb 1, 2024
View reviewed changes
Copy link

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Roseline-Bassey . See my comments above

docs/working-with-projects/working-with-images/sign-images.md Show resolved Hide resolved
docs/working-with-projects/working-with-images/sign-images.md Outdated Show resolved Hide resolved
docs/working-with-projects/working-with-images/sign-images.md Outdated Show resolved Hide resolved
docs/working-with-projects/working-with-images/sign-images.md Outdated Show resolved Hide resolved
@Roseline-Bassey
updated the existing Notation doc to address feedback from Feynman
acad03b 
Signed-off-by: Roseline <roselynbassey23@gmail.com>
@MinerYang MinerYang self-assigned this May 27, 2024
MinerYang
MinerYang approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wy65701436
wy65701436 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit a3003e4 into goharbor:main May 27, 2024
5 checks passed
@MinerYang
Copy link
Contributor

Hi @Roseline-Bassey ,

Appreciate your contribution to harbor community!

Best,
Miner

@FeynmanZhou
Copy link

Hi @wy65701436 @MinerYang ,

The changes of this PR seem not reflect on the Harbor website: https://goharbor.io/docs/2.10.0/working-with-projects/working-with-images/sign-images/#use-notationexperimental-to-sign-artifacts-with-distribution-spec-v11-mode.

Is this normal?

@OrlinVasilev
Copy link
Member

@FeynmanZhou it needs to be cherry picked to 2.10
currently is available on the edge docs: https://goharbor.io/docs/edge/working-with-projects/working-with-images/sign-images/#use-notationexperimental-to-sign-artifacts-with-distribution-spec-v11-mode

@FeynmanZhou
Copy link

@FeynmanZhou it needs to be cherry picked to 2.10 currently is available on the edge docs: https://goharbor.io/docs/edge/working-with-projects/working-with-images/sign-images/#use-notationexperimental-to-sign-artifacts-with-distribution-spec-v11-mode

@OrlinVasilev
Understood. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou requested changes

@wy65701436 wy65701436 wy65701436 approved these changes

@MinerYang MinerYang MinerYang approved these changes

Assignees

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

@AllForNothing AllForNothing

@MinerYang MinerYang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the existing Notation documentation
6 participants
@Roseline-Bassey @MinerYang @FeynmanZhou @OrlinVasilev @wy65701436 @AllForNothing