Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded image render hook does not retain fragment and query string #12468

Closed
jmooring opened this issue May 7, 2024 · 1 comment · Fixed by #12469
Closed

Embedded image render hook does not retain fragment and query string #12468

jmooring opened this issue May 7, 2024 · 1 comment · Fixed by #12469
Assignees
@jmooring
Labels
Bug Feature: Embedded Template Outdated

Comments

@jmooring
Copy link
Member

jmooring commented May 7, 2024

Reference: https://discourse.gohugo.io/t/the-embeded-image-render-hook-removes-uri-fragment-of-src-attribute/49684

The embedded link render hook retains the fragment and query string...

hugo/tpl/tplimpl/embedded/templates/_default/_markup/render-link.html

Lines 11 to 17 in c46d603

{{- $href = .RelPermalink -}}
{{- with $u.RawQuery -}}
{{- $href = printf "%s?%s" $href . -}}
{{- end -}}
{{- with $u.Fragment -}}
{{- $href = printf "%s#%s" $href . -}}
{{- end -}}

But the embedded image render hook does not.

hugo/tpl/tplimpl/embedded/templates/_default/_markup/render-image.html

Line 5 in c46d603

{{- $src = .RelPermalink -}}

@jmooring jmooring self-assigned this May 7, 2024
jmooring added a commit to jmooring/hugo that referenced this issue May 7, 2024
@jmooring
tpl/tplimpl: Retain query string and fragment in render-image.html
a8ca696 
Closes gohugoio#12468
@jmooring jmooring mentioned this issue May 7, 2024
Merged
bep pushed a commit that referenced this issue May 10, 2024
@jmooring @bep
tpl/tplimpl: Retain query string and fragment in render-image.html
6dfeb9f 
Closes #12468
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Bug Feature: Embedded Template Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tpl/tplimpl: Retain query string and fragment in render-image.html jmooring/hugo
1 participant
@jmooring