Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Add "retryDoer/hystrixDoer" implementation #69

Open
MichaHoffmann opened this issue Sep 4, 2019 · 1 comment
Open

[ENHANCEMENT] Add "retryDoer/hystrixDoer" implementation #69

MichaHoffmann opened this issue Sep 4, 2019 · 1 comment

Comments

@MichaHoffmann
Copy link

When comparing https://github.com/gojek/heimdall/blob/master/httpclient/client.go and https://github.com/gojek/heimdall/blob/master/hystrix/hystrix_client.go it seems that they only differ fundamentally in their respective Do methods. One could factor that part out into seperate Doer implementations and only have one httpclient implementation that delegates to a configurable Doer.

I would be willing to file a PR if that is acceptable.
@rShetty
Copy link
Contributor

rShetty commented Sep 6, 2019

Sure @MichaHoffmann you can work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rShetty @MichaHoffmann