Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured Output breaking. #79

Open
RangerFrank opened this issue Apr 24, 2024 · 6 comments
Open

Structured Output breaking. #79

RangerFrank opened this issue Apr 24, 2024 · 6 comments

Comments

@RangerFrank
Copy link

!!! Exception during processing !!!
Traceback (most recent call last):
File "D:\AI\ComfyUI\ComfyUI\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI\ComfyUI\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI\ComfyUI\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI\ComfyUI\custom_nodes\ComfyUI_VLM_nodes\nodes\suggest.py", line 611, in keyword_extract
parsed_response = json.loads(response)
^^^^^^^^^^^^^^^^^^^^
File "json_init_.py", line 346, in loads
File "json\decoder.py", line 337, in decode
File "json\decoder.py", line 353, in raw_decode
json.decoder.JSONDecodeError: Unterminated string starting at: line 3 column 15 (char 17)

@MilitantHitchhiker
Copy link

!!! Exception during processing !!!
Traceback (most recent call last):
File "D:\AI\ComfyUI\ComfyUI\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI\ComfyUI\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI\ComfyUI\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI\ComfyUI\custom_nodes\ComfyUI_VLM_nodes\nodes\suggest.py", line 611, in keyword_extract
parsed_response = json.loads(response)
^^^^^^^^^^^^^^^^^^^^
File "json_init_.py", line 346, in loads
File "json\decoder.py", line 337, in decode
File "json\decoder.py", line 353, in raw_decode
json.decoder.JSONDecodeError: Unterminated string starting at: line 3 column 15 (char 17)

@MilitantHitchhiker
Copy link

Over and over and over. keeps breaking workflows and preventing continuous processing without babysitting the node.

@gokayfem
Copy link
Owner

which llm you are using?

@MilitantHitchhiker
Copy link

MilitantHitchhiker commented Apr 27, 2024

llava 1.6 7b.Q5 mistral

@gokayfem
Copy link
Owner

maybe you can use more json output oriented llm, like nous hermes type llms, you can find their gguf files in huggingface

@MilitantHitchhiker
Copy link

MilitantHitchhiker commented Apr 27, 2024

Unfortunately the hermes models kind of suck for this purpose, the llava base models give significantly better outputs, any chance of adding some basic formatting error handling into the node?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants