Default benchmark profiling options fail

[EtiennePerot]

Description

Running a benchmark like:

$ make run-benchmark BENCHMARKS_TARGETS=test/benchmarks/base:syscallbench_test RUNTIME=runsc

(which uses the default value for BENCHMARKS_PROFILE which is -pprof-dir=/tmp/profile -pprof-cpu -pprof-heap -pprof-block -pprof-mutex)

... results in warnings about the profiling not working:

BenchmarkSyscallbench
BenchmarkSyscallbench/syscall.getpid
BenchmarkSyscallbench/syscall.getpid-20                  4328344              7638 ns/op
    container.go:563: warning: profile.Stop failed: exit status 128
BenchmarkSyscallbench/syscall.getpidopt
BenchmarkSyscallbench/syscall.getpidopt-20               4314039              7664 ns/op
    container.go:563: warning: profile.Stop failed: exit status 128
BenchmarkSyscallUnderSeccomp
BenchmarkSyscallUnderSeccomp/cacheable.false
BenchmarkSyscallUnderSeccomp/cacheable.false-20          4327574              7987 ns/op
    container.go:563: warning: profile.Stop failed: exit status 128
BenchmarkSyscallUnderSeccomp/cacheable.true
BenchmarkSyscallUnderSeccomp/cacheable.true-20           4307728              7908 ns/op
    container.go:563: warning: profile.Stop failed: exit status 128

... and no profiles stored under /tmp/profile.

Steps to reproduce

$ make run-benchmark BENCHMARKS_TARGETS=test/benchmarks/base:syscallbench_test RUNTIME=runsc

runsc version

Head

docker version (if using docker)

Unrelated

uname

6.6.15

kubectl (if using Kubernetes)

N/A

repo state (if built from source)

head

runsc debug logs (if available)

No response

[vax-r]

@EtiennePerot
I'm working on the issue now, I found that the main reason might be related with runsc package.
If we run the command $ make benchmark-platforms BENCHMARKS_TARGETS=test/benchmarks/base:syscallbench_test, we'll get numerous profiling files under /tmp/profile . However, the files under /tmp/profile/runsc/ are missing as you mentioned in the issue.

Those profiling files for the runtime runsc should be created via

gvisor/runsc/profile/profile.go

Line 103 in 211bb0f

func Start(opts Opts) func() {

. I follow the steps from make dev then sudo make run-benchmark BENCHMARKS_TARGETS=test/benchmarks/base:syscallbench_test RUNTIME=runsc , I found the Start() function under runsc profile package is never called.
I want to ask in what step should the runsc profile Start() function be called ?
If it's called properly then the files should be created ,too.