Dealing with event handler bubbling

[richard-to]

The scenario that brought this up was the use of a Modal where I wanted to be able to close the modal when clicking on the background.

In this scenario, if I click on the modal content to say copy and paste some text, the Modal will still close since the Modal background click event gets triggered.

This seems like expected behavior. I was wondering how we would prevent this from happening? Would we need to add a noop click event at the modal container/content. Would that prevent the event on the background from being triggered, or would both events get propagated? I can't quite remember what the behavior is but I'll test it out when I get the chance.

[wwwillchen]

Interesting, I think if we called event.stopPropagation then it would stop the event bubbling which would fix the issue you've described. We'd probably want to be consistent across all of our components.

One tricky part is how the Mesop app developer conveys this intent. For example, the following does not work:

def on_click(e):
  # by the time you call this, it's too late
  e.stop_propagation()

Instead, we'd probably need an API more like

@me.event_handler(stop_propagation=True)
def on_click(e):
  ...

Essentially we need to know when the function is binded at the component call site whether to stop future event propagations or not.

This seems a bit of a complex API and I'm wondering now if we should always call stopPropagation on behalf of users. It seems like the default behavior of always stopping propagation is probably what most developers want and then if people wanted to keep propagation, we could add this as a future feature (using an API like the above).

[richard-to]

Yeah, I guess there's two different issues being discussed here.

I think in my modal example I described the issue wrong since it's not bubbling up the events. Though I agree that the stopPropagation thing could become an issue. I agree also that stop propagation seems like a reasonable default behavior. I'm trying to think if there are more complicated stop propagation edge cases.

---

Back to the modal issue. The problem is that the click event is being triggered against the child component which I think is reasonable behavior in many cases, such as:

with me.box(on_click=on_click):
    me.text("Click me")

So the modal case, I think in javascript, I think I typically would check the event target. Is the element the modal div or is this the modal container? If modal div, then close. If not, then noop.

[wwwillchen]

I see what you're saying right now, basically it's the distinction between event.target and event.currentTarget. Right now, for each event, the key is effectively the event.currentTarget (where the event handler is attached), but it sounds like sometimes you want event.target - we could add a second property to MesopEvent like target_key.

I'm also wondering if we should actually have modal/dialog be a first-class component. It's kind of a tricky thing to implement correctly (even aside from this issue). I've filed #278