Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix overload methods of generic type #255

Closed
wants to merge 3 commits into from
Closed

fix overload methods of generic type #255

wants to merge 3 commits into from

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Jul 16, 2023 •
edited

fix goplus/gop#1396

const GopPackage = true

type Data[T any] struct {
	v T
}

func (p *Data[T]) Foo__0() {
}
func (p *Data[T]) Foo__1(a string, t T) {
}

NewOverloadMethod

recv type: *overloadFuncType
recv name: __gop_overload__:Foo__0;Foo__1
func (name type) Foo()

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (b1467c0) 94.47% compared to head (998bfa3) 94.49%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   94.47%   94.49%   +0.01%     
==========================================
  Files          14       14              
  Lines        6338     6355      +17     
==========================================
+ Hits         5988     6005      +17     
  Misses        282      282              
  Partials       68       68
Impacted Files Coverage Δ
codebuild.go 95.93% <100.00%> (+0.02%) ⬆️
func.go 97.43% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@visualfc visualfc closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go generic type methods does not recognize overload
2 participants
@visualfc @codecov-commenter