Don't use custom serialization when reporting type validation problems #29189
+438
−1,398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donat
commented
May 17, 2024
Comment on lines
+241
to
+242
| if (serviceClass.isAssignableFrom(InternalProblems.class)) { | ||
| return allServices.find(InternalProblems.class); |
There was a problem hiding this comment.
Thank you for looking into this @hegyibalint!
There was a problem hiding this comment.
Trivial solution, isn't it?!... 😂
donat
force-pushed
the
donat/problems/no-json
branch
from
5e85e4b
to
ed36a1d
Compare
donat
force-pushed
the
donat/problems/no-json
branch
from
344f636
to
0faa7f2
Compare
|
I've triggered the following builds for you. Click here to see all build failures. |
donat
force-pushed
the
donat/problems/no-json
branch
from
1518456
to
ccbf9c3
Compare
|
I've triggered the following builds for you. Click here to see all build failures. |
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
donat
commented
Jun 3, 2024
Comment on lines
+27
to
+28
| api(project(":build-operations")) | ||
| api(projects.serviceProvider) |
There was a problem hiding this comment.
SanityCheck failed wo/this change.
donat
commented
Jun 3, 2024
| ] | ||
| } | ||
|
|
||
| verifyAll(receivedProblem(0)) { |
There was a problem hiding this comment.
I only removed the if statement.
donat
commented
Jun 3, 2024
| @@ -16,6 +16,6 @@ | |||
|
|
|||
| package org.gradle.plugin.devel.tasks | |||
|
|
|||
| class CommonPluginValidationIntegrationTest extends AbstractPluginValidationIntegrationSpec implements ValitdatePluginsTrait { | |||
| class CommonPluginValidationIntegrationTest extends AbstractPluginValidationIntegrationSpec implements ValidatePluginsTrait { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29188