About newTestNetworkManager

[inancgumus]

@imiric

I replaced the following code:

xk6-browser/common/network_manager_test.go

Lines 33 to 65 in 112193c

	func newTestNetworkManager(t *testing.T, k6opts k6lib.Options) (*NetworkManager, *testSession) {
	ctx := context.Background()
	root, err := k6lib.NewGroup("", nil)
	require.NoError(t, err)
	state := &k6lib.State{
	Options: k6opts,
	Logger: k6test.NewLogger(t),
	Group: root,
	BPool: bpool.NewBufferPool(1),
	Samples: make(chan k6stats.SampleContainer, 1000),
	Tags: k6lib.NewTagMap(map[string]string{"group": root.Path}),
	BuiltinMetrics: k6metrics.RegisterBuiltinMetrics(k6metrics.NewRegistry()),
	}
	ctx = k6lib.WithState(ctx, state)
	logger := NewLogger(ctx, state.Logger, false, nil)
	session := &testSession{
	Session: &Session{
	id: "1234",
	},
	}
	nm := &NetworkManager{
	ctx: ctx,
	logger: logger,
	session: session,
	}
	return nm, session
	}

With this one and it still works:

func newTestNetworkManager(t *testing.T, k6opts k6lib.Options) (*NetworkManager, *testSession) {
	session := &testSession{
		Session: &Session{
			id: "1234",
		},
	}

	nm := &NetworkManager{
		ctx: k6lib.WithState(
			context.Background(),
			&k6lib.State{Options: k6opts},
		),
		session: session,
		resolver: k6mockres.New(map[string][]net.IP{
			mockHostname: {
				net.ParseIP("127.0.0.10"),
				net.ParseIP("127.0.0.11"),
				net.ParseIP("127.0.0.12"),
				net.ParseIP("2001:db8::10"),
				net.ParseIP("2001:db8::11"),
				net.ParseIP("2001:db8::12"),
			},
		}, nil),
		logger: NewNullLogger(),
	}

	return nm, session
}

Pardon me, but I've been wondering do we need the rest of the code?

[imiric]

Probably not for the particular tests it's used in, but I think it's a good idea to leave it for completion. If a test does need those other State fields, I'd rather they're already there, than have to troubleshoot an obscure panic in k6 because they're missing.

So I'd prefer leaving it in, but feel free to open a PR, and in general for these cases we can dicuss it in the PR.