Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid test failures when screenshot upload fails due to rate limiting #1339

Open
2 tasks
ankur22 opened this issue May 21, 2024 · 0 comments
Open
2 tasks

Avoid test failures when screenshot upload fails due to rate limiting #1339

ankur22 opened this issue May 21, 2024 · 0 comments
Labels
next Might be eligible for the next planning (not guaranteed!) remote remote browser related

Comments

@ankur22
Copy link
Collaborator

ankur22 commented May 21, 2024

What?

When a screenshot is upload to a remote location, when it fails, the whole of the test iteration fails. This is confusing behaviour and in most cases the end user may not be able to action on the failure to prevent it from happening (other than disabling screenshots).

Why?

Screenshots on a whole can be looked upon as a source of information to debug an issue or an extra human step to verify that the site is being displayed correctly. If it fails to upload to the remote server due to a rate limit, it shouldn't stop the core test to fail. This is likely lead users to a false positive and less trust in the test and therefore the product.

How?

Logs is a good example. When a log fails due to rate limiting when uploading to a remote location, the logs are ignored but an error log is printed instead. The test itself continues as always. We want to mimic this behaviour for screenshots in the same rate limited case.

Tasks

Tasks

Related PR(s)/Issue(s)

No response

@ankur22 ankur22 added remote remote browser related next Might be eligible for the next planning (not guaranteed!) labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next Might be eligible for the next planning (not guaranteed!) remote remote browser related
Projects
None yet
Development

No branches or pull requests

1 participant