[Bug]: OAuth fails for Azure AD external users due to # in user id

[nazarewk]

What happened?

Azure AD external users are in format: user.name_external.domain.com#EXT#@internaltenant.onmicrosoft.com for user user.name@external.domain.com and internaltenant , which does not pass the internal check due to presence of #:

netmaker/models/structs.go

Lines 274 to 282 in 630c95c

	func (user *User) NameInCharSet() bool {
	charset := "abcdefghijklmnopqrstuvwxyz1234567890-."
	for _, char := range user.UserName {
	if !strings.Contains(charset, strings.ToLower(string(char))) {
	return false
	}
	}
	return true
	}

Version

v0.22.0

What OS are you using?

Linux

Relevant log output

[netmaker] 2024-01-18 09:45:56 error creating user, krzysztof.nazarewski_[REDACTED].com#EXT#@[REDACTED].onmicrosoft.com ; user not added

Contributing guidelines

• Yes, I did.

[nazarewk]

actually it is a lot more than just a # present in the SSO username, validation should be skipped completely as per #2776
it fails:

• max=40 and in_charset|email on username
• required and min=5 on password