Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow effect on layer should be applied to its children if fill is empty #169

Open
softmarshmallow opened this issue Jul 25, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@softmarshmallow
Copy link
Member

softmarshmallow commented Jul 25, 2022

Referring to images below, you can see the shadow on texts on origin design, but the output code renders shadow on it's container (div).

If the container (parent) has no fill, then the shadow effect should be applied to its children individually.
This issue is only dedicated to figma, how figma handles shadow on empty fill frames.

The possible solution for this would be altering tokens in tokenization stage, removing shadow effect from parent and applying it to its children. - I can't be sure if this is the best solution because it impacts the token tree itself.
The alternative is to handle this on post-tokenization step (which I cannot say where would be the best place to handle this.)

Origin design
Screen Shot 2022-07-25 at 11 46 01 AM

The output. (Now, wrong.)
Screen Shot 2022-07-25 at 11 47 08 AM

This is dedicated to figma platform.

ref: https://www.figma.com/file/iypAHagtcSp3Osfo2a7EDz/engine?node-id=4927%3A7312

@softmarshmallow softmarshmallow added the good first issue Good for newcomers label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant