Add Mistral support to Bedrock #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
feature/bedrock-mistral
branch
4 times, most recently
from
51cf7d7
to
36f066f
Compare
collindutter
force-pushed
the
feature/bedrock-mistral
branch
from
36f066f
to
2c6bbc8
Compare
dylanholmes
requested changes
Mar 25, 2024
| See this thread more more information: https://github.com/griptape-ai/griptape/issues/244 | ||
|
|
||
| Returns: | ||
| BedrockLlamaTokenizer: The tokenizer for this driver. |
There was a problem hiding this comment.
BedrockLlamaTokenizer -> looks like a copy/paste error
Comment on lines
+40
to
+44
| if self._tokenizer: | ||
| return self._tokenizer | ||
| else: | ||
| self._tokenizer = BedrockMistralTokenizer(model=self.prompt_driver.model) | ||
| return self._tokenizer |
There was a problem hiding this comment.
Super nit:
if self._tokenizer is None:
self._tokenizer = BedrockMistralTokenizer(model=self.prompt_driver.model)
return self._tokenizer| Args: | ||
| prompt_stack: The `PromptStack` to convert. | ||
| """ | ||
| system_input = next((i for i in prompt_stack.inputs if i.is_system()), None) |
There was a problem hiding this comment.
Why does this assume a max of one system input?
Should you raise an exception if this assumption violated (rather than ignoring silently)?
Comment on lines
+60
to
+65
| prompt_lines = [self.BOS_TOKEN] | ||
| for prompt_input in non_system_inputs: | ||
| if prompt_input.is_assistant(): | ||
| prompt_lines.append(f"{prompt_input.content}{self.EOS_TOKEN} ") | ||
| else: | ||
| prompt_lines.append(f"[INST] {prompt_input.content} [/INST]") |
There was a problem hiding this comment.
Won't this end up with unbalanced BOS/EOS tokens? I didn't quickly get a great understanding of the mistrial docs on hugging face. Is unbalanced BOS/EOS tokens ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #664