You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of an on-going effort to reduce to capabilities of organizations.controller, we should not allow an org to update an org's environments via the organization.controller's putOrganization method.
We should block that functionality and instead add it explicitly to the environment.controller. Currently, we're missing a putEnvironment method (currently only supports updating multiple environments).
It is also missing a deleteEnvironment method.
When we do this work, we should also split out the PermissionsClass.canCreateOrUpdateEnvironment method into separate canCreate and canUpdate methods, with the canUpdate method taking the shape of other canUpdate methods where we take in the existing environment, check to make sure the user has permission to update it, as well as the updates and make sure that after the updates, the user still have permission to edit.
Sample code for the canUpdate method (has not been tested, so just use as a starting point)
Description of Feature
As part of an on-going effort to reduce to capabilities of organizations.controller, we should not allow an org to update an org's environments via the
organization.controller
'sputOrganization
method.We should block that functionality and instead add it explicitly to the
environment.controller
. Currently, we're missing aputEnvironment
method (currently only supports updating multiple environments).It is also missing a
deleteEnvironment
method.When we do this work, we should also split out the
PermissionsClass.canCreateOrUpdateEnvironment
method into separatecanCreate
andcanUpdate
methods, with thecanUpdate
method taking the shape of othercanUpdate
methods where we take in the existing environment, check to make sure the user has permission to update it, as well as theupdates
and make sure that after the updates, the user still have permission to edit.Sample code for the
canUpdate
method (has not been tested, so just use as a starting point)Related Issues
canCreateOrUpdateEnvironment
- Migrates manageEnvironments to permission Class. #2484The text was updated successfully, but these errors were encountered: