Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat Code #18

Open
CSenshi opened this issue Apr 4, 2020 · 6 comments
Open

Reformat Code #18

CSenshi opened this issue Apr 4, 2020 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@CSenshi
Copy link

CSenshi commented Apr 4, 2020

It would be nice if instead of having only one function that just generates a string, we had a struct named 'struct graph' for example, that had this method, configurations and other utilities inside. Subsequently, it would be easier to change implementations of other methods without changing the interface.

Besides that, we can add other methods, e.g. one could be to plot several graphs together or show statistics. However, (from my standpoint) it is essential to rewrite code so that it supports structure which will implement methods. In addition, it would encourage other users to write code for this project and making contributions much easier.

DISCLAIMER: I don't mean to delete old code, because other projects might be using it, so I will just extend it to support classes.

@CSenshi
Copy link
Author

CSenshi commented Apr 4, 2020

If this project is still up and open I would like to work on it :)

@guptarohit
Copy link
Owner

@CSenshi good idea 👍 Yes, we gotta refactor Plot function, and I was also thinking to add support for multi-graph. Please feel free to create PR :)

p.s. sorry for the delayed response.

@bnMikheili
Copy link

@CSenshi I would like to work on this issue, if it's free for now.

@CSenshi
Copy link
Author

CSenshi commented Jun 8, 2020

@bnMikheili Feel free to work on it!

@guptarohit guptarohit added the help wanted Extra attention is needed label Jun 21, 2023
Repository owner deleted a comment from adannalyn Feb 20, 2024
@micrub
This comment was marked as a violation of GitHub Acceptable Use Policies
Repository owner deleted a comment from tim-tepia Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants
@micrub @guptarohit @CSenshi @bnMikheili and others