Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycbc_fit_sngl_trigs looks to have been abandoned, should we get rid of it? #4588

Open
GarethCabournDavies opened this issue Dec 15, 2023 · 3 comments
Assignees

Comments

@GarethCabournDavies
Copy link
Contributor

The code pycbc_fit_sngl_trigs hasn't been touched in years outwith find/replace style PRs and looks like it has been abandoned.

It isn't used in the github CI, or in any other use cases I know of. Should this be removed?

Assigning to @tdent as he is named in the copyright.

@tdent
Copy link
Contributor

tdent commented Dec 17, 2023

Is there any functionality that is not available in other code (presumably fit sngls split binned) ? Eg the KS test?

@GarethCabournDavies
Copy link
Contributor Author

The KS test and the plotting including errors are not in pycbc_fit_sngls_split_binned, but are in pycbc_fit_sngls_binned

@tdent
Copy link
Contributor

tdent commented Dec 18, 2023

Ah, there is also the possibility to save fit coeff values and associated numbers to a txt file via --output .. I guess this could be made available simply in fit_sngls_binned by printing the fit values to stdout / logging (then someone can redirect to a file if wanted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants