New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python H2OFrame constructor 'skipped_columns' doesn't work #15947
Comments
hi @sebhrusen @wendycwong, i have fixed this bug and wanted to test it, how can i run the test suite? Edit: figured it out |
Devanshusisodiya
added a commit
to Devanshusisodiya/h2o-3
that referenced
this issue
Feb 13, 2024
Devanshusisodiya
added a commit
to Devanshusisodiya/h2o-3
that referenced
this issue
Feb 13, 2024
Devanshusisodiya
added a commit
to Devanshusisodiya/h2o-3
that referenced
this issue
Feb 13, 2024
hi @wendycwong @sebhrusen, raised a pr #16071 for the fix of this issue. please review and comment. |
hi @tomasfryda @wendycwong, can you take a look at the pr #16071 |
wendycwong
pushed a commit
that referenced
this issue
Apr 18, 2024
…specified when calling h2o.H2OFrame.
wendycwong
pushed a commit
that referenced
this issue
Apr 18, 2024
wendycwong
pushed a commit
that referenced
this issue
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When constructing a
H2OFrame
in Python using the constructor, theskipped_columns
parameter systematically causes a bug due to a mismatch during the call toparse_setup
Expected result
Discovered when writing tests for #15898
See test in h2o-py/tests/testdir_apis/Data_Manipulation/pyunit_h2oH2OFrame.py
Note that
h2o.parse_setup
function in Py looks particularly meesy with a lot of logic done on client side when it could probably be done server-side:j = api("POST /3/ParseSetup", data=kwargs)
) passing only some of the paramsThis looks weird, why not let the ParseSetup figure out all the good params?
The text was updated successfully, but these errors were encountered: