Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video component #2173

Open
TomDarmon opened this issue Oct 23, 2023 · 1 comment
Open

Video component #2173

TomDarmon opened this issue Oct 23, 2023 · 1 comment
Labels
feature Feature request ui Related to UI

Comments

@TomDarmon
Copy link

Is your feature request related to a problem? Please describe

I would like to be able to embedded videos natively in Wave. Currently the only work around I've found is with HTML:

def html_render_video(video_url: str, width: int, height: int):
    html = f"""
    <iframe src="{video_url}" 
    width="{width}" height="{height}" frameborder="0" allowfullscreen></iframe>
    """
    return html

card=ui.form_card(
            box=ui.box('video'),
            items=[
                ui.frame(
                    content=html_render_video(
                        video_url="https://www.youtube.com/embed/5qap5aO4i9A",
                        width='1600',
                        height='900',
                    ),
                ),
            ]
        )

It is not optimal as I lose a lot of the perfs of Wave when I used this kind of code :(

Describe the solution you'd like

A native wave component to embedded videos from a URL.

@TomDarmon TomDarmon added the feature Feature request label Oct 23, 2023
@mturoci mturoci added the ui Related to UI label Oct 24, 2023
@mturoci mturoci changed the title Component to embedded videos Video component Oct 24, 2023
@chandan00761
Copy link

Hi, I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request ui Related to UI
Projects
None yet
Development

No branches or pull requests

3 participants