Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Sorbet type checking green #57

Open
rickmark opened this issue Aug 12, 2022 · 1 comment
Open

Get Sorbet type checking green #57

rickmark opened this issue Aug 12, 2022 · 1 comment

Comments

@rickmark
Copy link
Member

(base) ➜ apple-knowledge git:(sorbet_fix) srb tc
_packages/ruby/lib/apple_data.rb:12: This function does not have a sig https://srb.help/7017
12 |def get_data(file)
^^^^^^^^^^^^^^^^^^

_packages/ruby/lib/apple_data.rb:10: Constants must have type annotations with T.let when specifying # typed: strict https://srb.help/7027
10 |APPLE_DATA_SHARE = File.join(File.dirname(FILE), '../share/')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Autocorrect: Use -a to autocorrect
_packages/ruby/lib/apple_data.rb:10: Replace with T.let(File.join(File.dirname(FILE), '../share/'), String)
10 |APPLE_DATA_SHARE = File.join(File.dirname(FILE), '../share/')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

_tools/lib/common.rb:85: Splats are only supported where the size of the array is known statically https://srb.help/7019
85 | load_file(*parts)
^

_tools/lib/common.rb:91: Splats are only supported where the size of the array is known statically https://srb.help/7019
91 | @filename = File.join(DATA_DIR, File.join(*parts))
^
Errors: 4

@Lil-Gitty-Kat
Copy link

Lil-Gitty-Kat commented Apr 22, 2023

row

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants