Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork and continue maintain midea_ac_lan as origin owner have no reponse for 7 month with new issue and PR #3682

Closed
4 tasks done
wuwentao opened this issue May 13, 2024 · 3 comments
Assignees
Labels
flag Flagging of repository that should be removed from HACS

Comments

@wuwentao
Copy link

Repository

georgezhao2010/midea_ac_lan

Checklist

  • I understand that this form should only be used for repositories that needs to be removed from HACS
  • I understand that a bug is not reason enough to have a repository removed
  • The repository is currently shipped as a default repository in HACS
  • I have tried to get the authors attention to the reason for removal

Why should this be removed?

Description:

if we install midea_ac_lan from HACS, it can't work any more , just return an unkown error.
as the hacs.json input an error file name mieda_ac_lan.zip, the right name should be midea_ac_lan.zip

old repo URL that can't work : https://github.com/georgezhao2010/midea_ac_lan
the hacs domain: midea_ac_lan
the hacs name: Midea AC Lan

Plan:

most github user report issue and PR about it, got no any reponse for a long time.
now I'm decide to fork and continue maintainer with it in future

https://github.com/wuwentao/midea_ac_lan (it should a works verion with the error fix and some new PR merged.)

and I' also send send email to the origin maintainer, got no repsone.
report a github issue in the origin repo:
georgezhao2010/midea_ac_lan#517

Question:

I'm not sure with how to do it now, so I just file a new PR to check and confirm with it ,then i will file PR to follow the rule with our suggestion.

Option 1. file PR to replace my forked repo with old repo? and continue maintain it in future ?
Option 2. or remove old midea_ac_lan or temp black list? and add a new name with it and file to hacs default?

Thanks
Wentao

Link to issue

georgezhao2010/midea_ac_lan#517

@wuwentao wuwentao added the flag Flagging of repository that should be removed from HACS label May 13, 2024
@hacs-bot
Copy link

hacs-bot bot commented May 13, 2024

Make sure you have read the issue guidelines and that you filled out the entire template.

If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a 👍 reaction to the issue description. Thanks! 👍

@tjorim
Copy link

tjorim commented May 13, 2024

We never 'replace' a repo. Open an issue or PR to remove the old one. Afterwards open a PR to add your fork. Just make sure you read all the requirements.

@wuwentao
Copy link
Author

wuwentao commented May 13, 2024

got it, thank you very much for your help and answer.
I will try to remove old one, then add the fork again.
edit and add remove PR info: hacs/default#2504

@ludeeus ludeeus closed this as completed May 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag Flagging of repository that should be removed from HACS
Projects
None yet
Development

No branches or pull requests

3 participants