Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test environment and test code quality #47

Open
Tracked by #220
towe75 opened this issue Jul 7, 2020 · 0 comments
Open
Tracked by #220

Improve test environment and test code quality #47

towe75 opened this issue Jul 7, 2020 · 0 comments
Labels
stage/accepted theme/testing type/enhancement

Comments

@towe75
Copy link
Collaborator

towe75 commented Jul 7, 2020

Podman version

We're using a dated podman version in our unit tests. It's installed from the projectatomic ppa but the recommended repo is now hosted at opensuse.org.

Code quality

driver_test has a lot of repetitive boilerplate code, we should refactor some often used patterns into tool functions. Also there is a unnecessary, hardcoded, 2 second timeout for some tests, see #45 (review).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage/accepted theme/testing type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrasell @towe75