New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash when opening repo with V3 pack files #10660
Comments
Is there anything special about the git repository used in this project? From the backtrace it looks like gitoxide is having trouble parsing some of the git data |
CC @Byron I think this is related to the sha-256 transisition. Maybe some new git versions now generate v3 pack files? It would be nice to support them but if gix can't do that for now not panicking and just emitting an error would be good. |
Yes, I agree! I will see to add support for whatever that is - it's not pack V3 I think as that would fail gracefully elsewhere. It's surprising that older Git can handle this in a fashion that doesn't involve dying. |
Related to helix-editor/helix#10660 which runs into object types that are unknown. I have looked into this and [couldn't find evidence of a new pack-entry type](https://github.com/git/git/blob/0f3415f1f8478b05e64db11eb8aaa2915e48fef6/packfile.c#L1303-L1358) in the Git codebase. It also looks like that Git [will never write packs that aren't V2](https://github.com/git/git/blob/0f3415f1f8478b05e64db11eb8aaa2915e48fef6/pack-write.c#L352) - initially I thought it might write V3 based on some other criteria. For now, the thesis is that one would have to be able to mark bad objects to be able to handle this more gracefully, but all we can do is try to fail.
I have looked into this and couldn't find evidence of a new pack-entry type in the Git codebase. It also looks like that Git will never write packs that aren't V2 - initially I thought it might write V3 based on some other criteria. It seems what Git would do in this case is to mark the object as bad and fail to decode it. Now |
Summary
I tried to open a VHDL file. It is a V3 version.
The file did not open and Helix crashed.
Update : After some tries, it seems that i can't open any file in a specific folder
Reproduction Steps
I tried this:
hx file.v
hx test.md
Helix log
No details in ~/.cache/helix/helix.log
Error whitout RUST_BACKTRACE=full :
Platform
Linux Debian 12, kernel 6.1.0-20-amd64
Terminal Emulator
Alacritty 0.11.0
Installation Method
source
Helix Version
helix 24.3 (a1d7997)
The text was updated successfully, but these errors were encountered: