You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're seeing that we cannot remove objects in dependent charts by setting the values to null , they will still get included in the result.
This used to work before, and this is causing apps deployed using ArgoCD to fail on probes getting introduced incorrectly (as they are defined in the dependent charts and cannot be nulled out).
This works well in ArgoCD 2.9.1, bot not in 2.9.2 which upgraded helm from 3.12.1 to 3.13.2, so the issue got introduced between those versions. I suspect this has to do something with this PR. The default template ProcessDependencies() got replaced with ProcessDependenciesWithMerge(), which ultimately does not remove null keys.
Please ignore that this is not functional this way, this is just to demonstrate the issue. In our real use case, this is causing probes getting incorrectly introduced, failing deployments in newer ArgoCD versions.
I have the same issue with Helm v3.14.4, while it was working some time ago. Will try to get my hands on older releases and check if those are working...
We're seeing that we cannot remove objects in dependent charts by setting the values to
null
, they will still get included in the result.This used to work before, and this is causing apps deployed using ArgoCD to fail on probes getting introduced incorrectly (as they are defined in the dependent charts and cannot be nulled out).
This works well in ArgoCD 2.9.1, bot not in 2.9.2 which upgraded helm from 3.12.1 to 3.13.2, so the issue got introduced between those versions. I suspect this has to do something with this PR. The default template
ProcessDependencies()
got replaced withProcessDependenciesWithMerge()
, which ultimately does not remove null keys.Related issues:
null
values do not remove keys from sub-charts #12637Issue
After running
helm template . -f values.yaml
inhelm-issue
(see setup below) andvalues.yaml
:Please ignore that this is not functional this way, this is just to demonstrate the issue. In our real use case, this is causing probes getting incorrectly introduced, failing deployments in newer ArgoCD versions.
Note: we get the correct result if we do
Minimal setup:
helm-issue/Chart.yaml
:helm-issue/values.yaml
:helm-dep/templates/deployment.yaml
:helm-dep/Chart.yaml
:helm-dep/values.yaml
:(Of course,
helm dependency update
has to be run)The text was updated successfully, but these errors were encountered: