Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: reconsider expect/got order #1181

Open
slimsag opened this issue Mar 10, 2024 · 0 comments
Open

testing: reconsider expect/got order #1181

slimsag opened this issue Mar 10, 2024 · 0 comments

Comments

@slimsag
Copy link
Member

slimsag commented Mar 10, 2024

Today we have:

try testing.expect(T, want).eql(got);

Worth considering if this is more correct by majority opinion:

try testing.expect(got).eql(T, want);

In other words - our little testing wrapper has failed to correctly express order more clearly than testing.expectEqual from the stdlib - that needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant