Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USCSLengthSurvey group is defined based on the survey foot which is now defunct #1912

Open
jacob-indigo opened this issue Jan 2, 2024 · 5 comments · May be fixed by #1920
Open

USCSLengthSurvey group is defined based on the survey foot which is now defunct #1912

jacob-indigo opened this issue Jan 2, 2024 · 5 comments · May be fixed by #1920

Comments

@jacob-indigo
Copy link

NGS and NIST announced in 2019 that after 2022, the survey foot (based on the 1893 definition of a foot) should no longer be used and all geodetic surveying should be based on the international foot (based on the 1959 definition of a foot). They released the following revised unit conversions: https://www.nist.gov/pml/us-surveyfoot/revised-unit-conversion-factors

Pint is still using the old conversions: https://github.com/hgrecco/pint/blob/29a139f0c31a056e15fbb13e3e6f827b56c4a9bb/pint/default_en.txt#L541C8-L541C24

@hgrecco
Copy link
Owner

hgrecco commented Jan 10, 2024

I think we should include this but with a reasonable deprecation warning.

@dalito
Copy link
Contributor

dalito commented Jan 10, 2024

Somewhat related: It would be great to have provenance information on the factors in in the units file. A more extensible file format would help realizing this (#1561).

@hgrecco
Copy link
Owner

hgrecco commented Jan 10, 2024

For the current format I have a few ideas that are easy to implement:

Inline

plain

bigstick = 4 stick # The one and only manual

with colon (similar to how attributes were documented at some point)

bigstick = 4 stick #: The one and only manual

with colon and a keyword (like # type :)

bigstick = 4 stick # source: The one and only manual

blocks

Current block syntax

@source The one and only manual
    # everything within this block has the same source
    bigstick = 4 stick
@end

Adding and removing a default source

# source: The one and only manual
# everything without source within this block has the same source

bigstick = 4 stick

# source: 
# This line above set it to blank

In addition, all these could be connected to some form of indirection that could be useful if there is a lot of repetition.

bigstick = 4 stick # source: [1]

# source [1]: The one and only manual

I do not like@source, while consistent with everything else in the definitions file it would make it uglier and difficult to read. I favour a combination of plain and block.

@dalito
Copy link
Contributor

dalito commented Jan 10, 2024

For the current format I like the last form most. It is easy to remember and familiar to most as it matches citing in literature.

@jacob-indigo
Copy link
Author

I put up a PR for a first pass at this update. Let me know what you'd like to see from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants