Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Randomizer Raise Error When running on the CPU #5211

Open
Orion-Zheng opened this issue Dec 28, 2023 · 2 comments 路 May be fixed by #5265
Open

[BUG]: Randomizer Raise Error When running on the CPU #5211

Orion-Zheng opened this issue Dec 28, 2023 · 2 comments 路 May be fixed by #5265
Labels
bug Something isn't working

Comments

@Orion-Zheng
Copy link
Contributor

馃悰 Describe the bug

The Bug is raise from: https://github.com/hpcaitech/ColossalAI/blob/main/colossalai/moe/experts.py#L88

You can reproduce the error by simply running code below:

from colossalai.shardformer.layer.utils import Randomizer
Randomizer(42).fork_rng(enable_cpu=True)  # raise error if run on CPU

This will cause OpenMoE unable to initialize parameters on CPU.

Environment

No response
@Orion-Zheng Orion-Zheng added the bug Something isn't working label Dec 28, 2023
@Orion-Zheng
Copy link
Contributor Author

OK I fixed this issue, I will submit a PR soon.

@Orion-Zheng Orion-Zheng linked a pull request Jan 13, 2024 that will close this issue
Open
10 tasks
@flybird11111
Copy link
Contributor

Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Hotfix/randomizer]Fix Randomizer error on CPU Orion-Zheng/ColossalAI
2 participants
@flybird11111 @Orion-Zheng