Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on HF Hub error when streaming #6844

Closed
wants to merge 1 commit into from

Conversation

mariosasko
Copy link
Collaborator

Retry on the huggingface_hub's HfHubHTTPError in the streaming mode.

Fix #6843

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though usually we retry only on 5xx errors no?

@mariosasko
Copy link
Collaborator Author

@Wauplin This PR is indeed not needed as explained in #6843 (comment).

So, I'm closing it.

@mariosasko mariosasko closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IterableDataset raises exception instead of retrying
3 participants