Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming] Only load requested splits without resolving files for the other splits #6847

Open
lhoestq opened this issue Apr 29, 2024 · 2 comments
Assignees

Comments

@lhoestq
Copy link
Member

lhoestq commented Apr 29, 2024

e.g. thangvip/cosmopedia_vi_math has 300 splits and it takes a very long time to load only one split.

This is due to load_dataset() resolving the files of all the splits even if only one is needed.

In dataset-viewer the splits are loaded in different jobs so it results in 300 jobs that resolve 300 splits -> 90k calls to /paths-info

@lhoestq lhoestq self-assigned this Apr 29, 2024
@lhoestq
Copy link
Member Author

lhoestq commented Apr 29, 2024

This should help fixing this issue: #6832

@akaashdash
Copy link

akaashdash commented May 7, 2024

I'm having a similar issue when using splices:
image
image
image

It seems to be downloading, loading, and generating splits using the entire dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants