Unpin hfh #6876
Unpin hfh #6876
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
As I explain in the corresponding issue that I self-assigned (#6863), I was planning to unpin the upper bound of huggingface-hub < 0.23.0 only when the huggingface/transformers#30618 fix is merged and released in a new transformers version, otherwise it breaks our CI. The fix has been merged but not released yet.
Also note that datasets-2.19.1 (version currently installed in the dataset-viewer) does not include the pin in huggingface-hub:
https://github.com/huggingface/datasets/blob/2.19.1/setup.py#L138
Line 138 in bb2664c
If we urgently need some dev feature for dataset-viewer, I would suggest pushing the feature (cherry-picked) to a dedicated branch with 2.19.1 as its starting point (without opening a PR), and install datasets from that branch.
|
transformers 4.40.2 was release yesterday but not sure if it contains the fix |
|
@lhoestq yes I knew transformers 4.40.2 was released yesterday, but I had checked that it does not contain the fix: only 2 bug fixes. That is why our CI continues failing in this PR. We will have to wait until the next minor version. |
I have done so:
|
|
hfh 0.23.1 and transformers 4.41.0 as are out out, let's unpin no ? |
|
I have re-run the CI to check that is green before. |
Needed to use those in dataset-viewer:
close #6863