Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo build fails for python bindings when --locked is passed for v0.15.1 and v0.15.2 #1477

Open
CobaltCause opened this issue Mar 22, 2024 · 3 comments
Labels

Comments

@CobaltCause
Copy link

I noticed that at least the git tags listed in the title forgot to update Cargo.lock in addition to Cargo.toml. This discrepancy causes cargo build --locked to fail with an error like this:

error: the lock file /.../tokenizers/bindings/python/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.

Passing --locked is required for e.g. certain distro packaging methodologies. Also, it means that running cargo build without --locked will work but leave your git tree dirty, which is kinda weird.

Obviously this isn't really retroactively fixable, but hopefully this can be avoided in future releases. Maybe a check for this can be added in CI?

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@CobaltCause
Copy link
Author

@github-actions github-actions bot removed the Stale label Apr 23, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant