Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grounding DINO missing custom kernels #30765

Closed
2 of 4 tasks
sam-ulrich1 opened this issue May 11, 2024 · 2 comments · Fixed by #30768
Closed
2 of 4 tasks

Grounding DINO missing custom kernels #30765

sam-ulrich1 opened this issue May 11, 2024 · 2 comments · Fixed by #30768
Labels

Comments

@sam-ulrich1
Copy link

System Info

Latest including master as of 5/11/24
Ubuntu, 4090 GPU

Who can help?

@amyeroberts

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

When running any GroundingDINO model you get the following. I have confirmed the kernels do not exist in the transformers repo:

Could not load the custom kernel for multi-scale deformable attention: [Errno 2] No such file or directory: '/.../transformers-main/src/transformers/kernels/grounding_dino/vision.cpp'".
Could not load the custom kernel for multi-scale deformable attention: [Errno 2] No such file or directory: '.../transformers-main/src/transformers/kernels/grounding_dino/vision.cpp'".

Expected behavior

Either the kernels are not necessary and should be removed or they are necessary and causing performance issues. GroundingDINO does seem to under perform in transformers but this is purely anecdotal

@NielsRogge
Copy link
Contributor

cc @EduardoPach

Regarding

GroundingDINO does seem to under perform in transformers but this is purely anecdotal

Could you clarify? Text queries need to be lowercased + end with a dot

@EduardoPach
Copy link
Contributor

Hey @sam-ulrich1 thanks for opening this Issue! GroundingDino was missing the ms_deform_attn_kernels this was something that we overlooked when we merged the model to the library. I have opened this PR #30768 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants