Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config to systeminfo or bug reports. #6098

Closed
The-Briel-Deal opened this issue May 16, 2024 · 5 comments · Fixed by #6160
Closed

Add Config to systeminfo or bug reports. #6098

The-Briel-Deal opened this issue May 16, 2024 · 5 comments · Fixed by #6160
Labels
enhancement New feature or request

Comments

@The-Briel-Deal
Copy link
Contributor

Description

I've ran into a bunch of bug reports recently that would have been a lot easier to repro if their config was in the bug report. I'm fine to add a config dump at the top of systeminfo so that its included when people include hyprctl systeminfo in their report. Another option is just adding a field for config in bug reports.

I feel like people don't really include personal info in configs but we can definitely warn people to take their social security number out of their config before submitting lol.

Thoughts on adding this? Is there a reason it hasn't been added?

@The-Briel-Deal The-Briel-Deal added the enhancement New feature or request label May 16, 2024
@rtgiskard
Copy link
Contributor

Or maybe an independent sub command like configdump, and require it on bug report

@vaxerski
Copy link
Member

fair enough

Is there a reason it hasn't been added?

yes, never thought of this and was bothered enough

@The-Briel-Deal
Copy link
Contributor Author

Or maybe an independent sub command like configdump, and require it on bug report

I kind of just want it to be as simple as possible for the reporter to get this in one command, I'm kind of thinking either a debuginfo hyprctl command that contains everything we might need or just add a --config, --logs, and --all flag to systeminfo. Pretty sure there is a hyprctl command already to log config. I'll make a quick PR and you guys can give me your thoughts.

@vaxerski
Copy link
Member

vaxerski commented May 16, 2024

flags make sense

@The-Briel-Deal
Copy link
Contributor Author

Addressed here: #6160

I updated the bug template and added a -c/--config flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants