Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox crashes on drag and drop. #6102

Open
EnolaGae opened this issue May 16, 2024 · 12 comments
Open

Firefox crashes on drag and drop. #6102

EnolaGae opened this issue May 16, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@EnolaGae
Copy link

Hyprland Version

System/Version info
Hyprland, built from branch main at commit 94c20a186372aace78b188842848b873eb3ebbd7  ().
Date: Mon May 13 08:47:59 2024
Tag: , commits: 4693

flags: (if any)


System Information:
System name: Linux
Node name: fedora
Release: 6.8.9-300.fc40.x86_64
Version: #1 SMP PREEMPT_DYNAMIC Thu May  2 18:59:06 UTC 2024


GPU information: 
07:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Rembrandt [Radeon 680M] [1002:1681] (rev c8) (prog-if 00 [VGA controller])


os-release: NAME="Fedora Linux"
VERSION="40 (Workstation Edition)"
ID=fedora
VERSION_ID=40
VERSION_CODENAME=""
PLATFORM_ID="platform:f40"
PRETTY_NAME="Fedora Linux 40 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:40"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f40/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=40
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=40
SUPPORT_END=2025-05-13
VARIANT="Workstation Edition"
VARIANT_ID=workstation


plugins:

Bug or Regression?

Bug

Description

When using Firefox, I crash instantly when doing a drag and drop (moving a tab, moving a text chunk, an image, etc).
I have only noticed this issue after updating to the May 13th branch.

How to reproduce

To reproduce, use Firefox ( Mozilla Firefox 125.0.3 ) and the latest version of hyprland-git ( commit 94c20a1 ) and open a tab. Then try to drag it around. Firefox should crash instantly.

Crash reports, logs, images, videos

Crash report

@EnolaGae EnolaGae added the bug Something isn't working label May 16, 2024
@PickNicko13
Copy link

Doesn't seem to happen on d693c44 and Librewolf 125.0.3

@vaxerski
Copy link
Member

vaxerski commented May 16, 2024

looks like a protocol error on firefox's side. Can you post WAYLAND_DEBUG=1 firefox logs of when it happens?

@EnolaGae
Copy link
Author

EnolaGae commented May 16, 2024

looks like a protocol error on firefox's side. Can you post WAYLAND_DEBUG=1 firefox logs of when it happens?

Sorry, but i'm not sure how to do that :x

> firefox --WAYLAND_DEBUG

[GFX1-]: Wayland protocol error: wl_display@1: error 1: invalid arguments for wl_data_offer@4278190086.accept

ExceptionHandler::GenerateDump cloned child 148745
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
ExceptionHandler::WaitForContinueSignal waiting for continue signal...
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.

This is a log of when I open Firefox and make it crash. I updated hyprland-git twice since making that report, and still get the issue. I'm using the copr repo on Fedora 40 if that can help too

@EnolaGae
Copy link
Author

Doesn't seem to happen on d693c44 and Librewolf 125.0.3

It does happen to me on librewolf as well. I'm on de9798f now. (I also cannot copy paste for some godforsaken reason, not sure if it is related or not - only seems to happen with firefox opened)

@vaxerski
Copy link
Member

can you try updating hyprwayland-scanner to git and then rebuilding hyprland?

@EnolaGae
Copy link
Author

EnolaGae commented May 16, 2024

can you try updating hyprwayland-scanner to git and then rebuilding hyprland?

Might be a dumb question but since I've been using the copr repo I'm not sure how to swap between the two?

@vaxerski
Copy link
Member

me neither, I dont use fedora. That's up to you to discover.

@EnolaGae
Copy link
Author

can you try updating hyprwayland-scanner to git and then rebuilding hyprland?

I am unable to build hyprland from source, due to dependencies missing (xwayland) when they aren't. I understand that it's an issue with the rewrite going on, though I might be a bit too dumb to understand the how or why :P rolled back to 0.40.0, and it works again.

@shogeki
Copy link

shogeki commented May 16, 2024

I can't reproduce the crash exactly, but dragging a tab out of firefox to another workspace used to work (somewhat), but now always goes to Workspace 1 regardless of where you drag it to. Spawning additional windows via a launcher or macro also only spawns your extra windows in Workspace 1.

There is also some new unintended behavior regarding how Firefox reopens windows after being closed via killactive. Sometimes now if I launch firefox, it opens 3 windows that were previously open. If I close them with killactive, they come back the next time firefox full launches (with no process already open). But if I kill them with clicking the X in the top right of the window, they do not come back.

All of these were working previously in v.0.40

@PickNicko13
Copy link

PickNicko13 commented May 17, 2024

Just checked and:

  1. dragging a tab to another monitor creates a window there;
  2. using a keybinding or launcher creates a new window on the current workspace (regardless of it's number).

What you described seems like it might be caused by window rules. Are you sure there aren't any rules about Firefox being on workspace 1 in your config(s)?

Note: still using commit d693c44 and LibreWolf 125.0.3.

@vaxerski
Copy link
Member

could also be initial workspace tracking

@shogeki
Copy link

shogeki commented May 17, 2024

Initial workspace tracking did fix the workspace 1 issue! I set to 2 to try to fix xwayland issues but 0 or 1 seems to work as normal

However, dragging firefox tabs into workspaces containing certain windows (e.g. alacritty, discord) results in a glitched or crashed firefox tab now for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants