0.24.0 alpha/beta
#625
Replies: 19 comments 58 replies
-
|
Template to report about your usage case:
For example:
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Replaced in first pet-project, later will add info about 3 more, but currently JS problem appeared
|
Beta Was this translation helpful? Give feedback.
3 replies
-
|
Also into details: tasks.withType<JavaCompile> {
options.encoding = "UTF-8"
} |
Beta Was this translation helpful? Give feedback.
-
|
thx for feedback. |
Beta Was this translation helpful? Give feedback.
-
|
i think 0.24.0-alpha-3 already have fix for this issue. can you check? |
Beta Was this translation helpful? Give feedback.
-
|
published alpha 2 - https://github.com/icerockdev/moko-resources/releases/tag/release%2F0.24.0-alpha-2 |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Hi @Alex009 I have static framework And the script is like this |
Beta Was this translation helpful? Give feedback.
21 replies
-
|
@Alex009 alpha-4 did not work for me either, same error as @egorikftp |
Beta Was this translation helpful? Give feedback.
-
Hi @Alex009, |
Beta Was this translation helpful? Give feedback.
-
|
@chris-houston |
Beta Was this translation helpful? Give feedback.
-
|
@ExNDY That work around you posted works for me 👍 |
Beta Was this translation helpful? Give feedback.
-
|
alpha-5 released, with fix copyResources task without cocoapods plugin |
Beta Was this translation helpful? Give feedback.
-
|
I have this setup: gradle-wrapper: gradle-8.2-bin and keep receiving this error on gradle sync as soon as I add the dependency to 0.24.0-alpha-2: I tried multiple different variants of kotlin/gradle versions so far :/ |
Beta Was this translation helpful? Give feedback.
4 replies
-
|
I have the same issue. It was introduced when I added android build flavors. Before that everything worked fine.
The only thing I did was to add: android {
// ...
flavorDimensions += "version"
productFlavors {
create("full") {
dimension = "version"
applicationIdSuffix = ".full"
}
create("lite") {
dimension = "version"
applicationIdSuffix = ".lite"
}
}
// ...
}Note: This error only seems to happen in Android Studio. Running Stacktrace |
Beta Was this translation helpful? Give feedback.
-
|
thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Having the same issue without the flavors. Kotlin version: 1.9.21 Project built with KMP wizard 1-2 weeks ago. build.gradle.kts (:composeApp) build.gradle.kts (root) settings.gradle.kts libs.versions.toml I hope it helps |
Beta Was this translation helpful? Give feedback.
-
|
issue should be fixed in 0.24.0-alpha-3 |
Beta Was this translation helpful? Give feedback.
-
|
published 0.24.0-alpha-3 version. |
Beta Was this translation helpful? Give feedback.
12 replies
-
|
I am also having the same issue when building on Xcode I did the migration correctly as well |
Beta Was this translation helpful? Give feedback.
-
|
@chris-houston your case should be fixed by 0.24.0-alpha-4 @zt64 your case something new. can you create simple reproducer project? |
Beta Was this translation helpful? Give feedback.
-
|
alpha-5 released, with fix copyResources task without cocoapods plugin |
Beta Was this translation helpful? Give feedback.
-
|
@Alex009 regarding an issue that @zt64 experienced, it can be reproduced on |
Beta Was this translation helpful? Give feedback.
-
|
@an22 I had the same issue (the previews were not working in androidMain), my fix for now was to set the sourceSet with the destination for the generated resources for android |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/icerockdev/moko-resources/releases/tag/release%2F0.24.0-alpha-4 released. fix copyResources task new case |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Hey,
|
Beta Was this translation helpful? Give feedback.
5 replies
-
|
hi. moko-resources support multimodule resources on each supported targets (for js too). you can check |
Beta Was this translation helpful? Give feedback.
-
|
Running |
Beta Was this translation helpful? Give feedback.
-
|
Running karma manually returns this |
Beta Was this translation helpful? Give feedback.
-
|
@Burtan hi. please check on 0.24.0-beta-4 |
Beta Was this translation helpful? Give feedback.
-
|
Seems to work fine now :-) |
Beta Was this translation helpful? Give feedback.
-
|
alpha-5 released, with fix copyResources task without cocoapods plugin |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Just gave it a try, main feedback is about the
Once this configured, everything worked fine though, thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
I just wondered, the MultiplatformResourcesPluginExtension doesnt include disableStaticFrameworkWarning anymore. Is there a new way to disable those build warnings? Ah, nevermore. I should learn to read. You now add it to the gradle properties. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
https://github.com/icerockdev/moko-resources/tree/%23535-kotlin-1.9.0-support?tab=readme-ov-file#disable-warning-about-static-framework-usage here readme of 0.24.0 now |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
0.24.0-beta-1 released. we will fix CI issues with JS and planing complete release at this. If somebody see some critical issues for this release - please report it in new issue. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
0.24.0-beta-2 released. please continue testing and feedback :) |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
0.24.0-beta-3 released. looks like we will fix:
and after it we can publish stable release |
Beta Was this translation helpful? Give feedback.
8 replies
-
|
Another new feedback, the iOS version(running in release mode)is very slow when loading for the first time, as shown in the video, it's a bad experience! Kapture.2024-05-08.at.20.14.19.mp4 |
Beta Was this translation helpful? Give feedback.
-
|
Strange. Can you provide your strings.xml? |
Beta Was this translation helpful? Give feedback.
-
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="hello_world">Hello moko-resources World</string>
<string name="label_count">Count:</string>
</resources>The iOS view I wrote using the Redwood framework and the same code works fine without the moko-resources. |
Beta Was this translation helpful? Give feedback.
-
|
need reproducer project for research issue. please create issue and attach reproducer |
Beta Was this translation helpful? Give feedback.
-
|
ios-cocoapods-static-framework.7z.zip Kapture.2024-05-09.at.14.21.23.mp4This is my modification based on your demo, and you can see that there is indeed a delayed response for moko to load. The first time the app is run, there is a delayed response for moko loading, and it is normal to repeat the operation later. |
Beta Was this translation helpful? Give feedback.
-
|
0.24.0-beta-4 released |
Beta Was this translation helpful? Give feedback.
2 replies
-
|
Hello, after switching to Opening the first link results in a 403 Forbidden Full Error |
Beta Was this translation helpful? Give feedback.
-
|
Your Gradle configuration invalid. Runtime library should be searched in mavenCentral but in your log it searched in gradlePlugins |
Beta Was this translation helpful? Give feedback.
-
|
Do we still need the karma and webpack generated conf files? |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
yes. karma required for unit tests executable. webpack required for application executable |
Beta Was this translation helpful? Give feedback.
-
|
Hey, moko-resources copies js test resources to the compileSync folder, while main resources are copied to the processResources folder. Regular resources are always copied to the processResources folder. What is the reasoning for that? |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
looks like js main and test executables have different destination directories in gradle. our copy actions attached to kotlin gradle plugin tasks and use their destinations |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is an alpha version. Bugs may be present. Any new features may change their API before release.
Changes
acToolMinimalDeploymentTarget)Breaking changes
src/<sourceSet>/resources/MRtosrc/<sourceSet>/moko-resourcesMR.fonts.Arial.italicnowMR.fonts.arial-italicMR.assets.dir.innerdir.myassetnowMR.assets.myasset- this will be fixed laterHow to update
0.24.0-alpha-1src/<sourceSet>/resources/MRtosrc/<sourceSet>/moko-resourcesresourcesSourceSet- now expect object will be generated in lower source set in hierarchymultiplatformResourcesvalues set from=tosetlikeresourcesPackage = "org.example.library"toresourcesPackage.set("org.example.library")if you use fonts or assets - you should update your code to new generation structure (no inner objects in fonts and assets now).
If you have some issues
At first please compare your setup with samples in release branch.
If you not find solution with samples - read next block.
Call to feedback
In this release gradle plugin was rewritten to fix fundamental problems. All sample projects now compiles and works fine, but in real projects can be some new cases that will not work. Please write us in attached to this release discussion. Write about successful works case, about bugs, any feedback about this release.
This discussion was created from the release 0.24.0-alpha-1.
Beta Was this translation helpful? Give feedback.
All reactions