Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit a Leetcode problem #49

Open
ignacio-chiazzo opened this issue Oct 2, 2022 · 9 comments
Open

Submit a Leetcode problem #49

ignacio-chiazzo opened this issue Oct 2, 2022 · 9 comments

Comments

@ignacio-chiazzo
Copy link
Owner

Pick a problem in Leetcode or any other platform.

If you find a solution, follow the next steps:

Open A PR that contains:

  1. Solution in a file with a description of the problem at the top.
  2. A test file with some test cases. The test file must export a test() function which will run all the tests of the file.
  3. An entry of the problem in the list of solutions within the README file.

PR Example: #39

If you don't find a solution but want to discuss a problem, I would be happy to! In that case, please submit an issue.

@piyush-sri
Copy link

i would like to work on this issue. Please assing it to me

@ignacio-chiazzo
Copy link
Owner Author

Hey! Thanks for showing interest!

This issue is generic. Feel free to grab any problem that is not in this repo and work on it. You can also submit an issue while you're tackling the problem.

@Faizan96322
Copy link

Faizan96322 commented Oct 3, 2022

hey, I would like to contribute my leetcode problems solutions in this repo!
can you pls explain the 2nd point "The test file must export a test() function which will run all the tests of the file."

@ignacio-chiazzo
Copy link
Owner Author

Hey thank you!

can you pls explain the 2nd point "The test file must export a test() function which will run all the tests of the file."

Sure, the PR needs to have a test file that tests a few scenarios. The file should have a main function test that is exported.

See example:

https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript/pull/39/files#diff-cc64c97de04332133c060ff52dd0c575e035b6e488f64e6f35229fc5673bf1e2R45-R51

const assert = require('assert');
const { theNewProblem } = require('../LeetcodeProblems/The_New_Problem.js');

function test() {
  // Test a few scenarios here like this:
    assert.strictEqual(theNewProblem, [.....]);
}

module.exports.test = test

@ignacio-chiazzo ignacio-chiazzo added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 6, 2022
@ignacio-chiazzo
Copy link
Owner Author

@deepesh85b you are welcome to contribute. No need to be assigned to this issue to work on it :). Thank you!

@kav1239
Copy link
Contributor

kav1239 commented Oct 20, 2022

Hey !
Could you please assign this ask to me i would like to contribute in this project

@ignacio-chiazzo
Copy link
Owner Author

@kav1239 you are welcome to contribute. No need to be assigned to this issue to work on it :). Thank you!

@ijaz-ali-dev
Copy link

Hi dear, can u assign me and please add the October label to confirm and start my contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@ignacio-chiazzo @ijaz-ali-dev @piyush-sri @Faizan96322 @kav1239 and others