Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Toggling favorite/unfavorite #424

Open
strk opened this issue Nov 25, 2023 · 1 comment
Open

[Feature Request] Toggling favorite/unfavorite #424

strk opened this issue Nov 25, 2023 · 1 comment

Comments

@strk
Copy link
Contributor

strk commented Nov 25, 2023

Right now when you press F in the TUI you declare to favorite a post, but you have no indication of the fact that you favorited it. If you press again you get an error and a backtrace printed on console (it's a bug).

This ticket is to request implementing a feature at the same time as fixing the bug, that is: give an indication of the post being favorite and make pressing F again remove the "favorite" flag.
@danschwarz
Copy link
Collaborator

My PR #261 addresses this issue. Not sure why it wasn't accepted a long time back. @ihabunek did you have a preference for a different solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@strk @danschwarz