Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Find Subtitle Result Window was too Narrow to see the whole name. #4057

Open
owenzhao opened this issue Nov 9, 2022 · 4 comments · May be fixed by #4825
Open

The Find Subtitle Result Window was too Narrow to see the whole name. #4057

owenzhao opened this issue Nov 9, 2022 · 4 comments · May be fixed by #4825

Comments

@owenzhao
Copy link

owenzhao commented Nov 9, 2022

What you want IINA to do:

The result window of find subtitle should be much much more wider.

What IINA does currently:

Too narrow to see the full name, we need to see the full name to get the subtitle that is mostly match my video.

Why you think this should be added:

Examples of other projects that have something similar:

@Iiii-I-I-I
Copy link

To complete the Why you think this should be added: field, here are some situations where I've needed to read the full filename:

  • to see the year of release, because there are multiple remakes with the same title
  • to see the format of the movie (streaming, Blu-ray, restoration, etc.), because the timings may be off
  • to see the type of subtitle (forced, CC, etc.), because I'm not hearing impaired and do not need SDH subtitles

This type of information is usually listed at the end, where it gets cut off by IINA's search window. Making sure I'm downloading the correct file is even more important for OpenSubtitles now that they've added a daily limit.

@Iiii-I-I-I
Copy link

Some possible solutions:

  • show the full text when hovering over the title, the same way title text appears when hovering over an <a> tag on the web. Could be less work than messing with the UI?
  • add more information to the metadata row (I don't know if the OpenSubtitles API gives you that kind of detail). Here is a mockup, with the current on the left and proposed on the right:

iina

@svobs
Copy link
Contributor

svobs commented Feb 17, 2024

show the full text when hovering over the title, the same way title text appears when hovering over an tag on the web. Could be less work than messing with the UI?

This is trivial (a checkbox in the UI). I may post a PR for it.

However, you can try another workaround, which exists because the table width is set by the width of its title. Try increasing the OSD text size in IINA's Settings:
SCR-20240216-unyk

@svobs svobs linked a pull request Feb 17, 2024 that will close this issue
2 tasks
@low-batt low-batt linked a pull request Feb 17, 2024 that will close this issue
2 tasks
@Iiii-I-I-I
Copy link

Thanks all for addressing this so quickly! I look forward to the title text + new plug-ins in a future update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants