Fix subtitles override level not localized, #4892 #4893
Conversation
This commit will: - Add key-value pairs for the yes, force and strip override levels to the base and en Localizable.strings files - Change the transformedValue method in the ASSOverrideLevelTransformer class to return a localized string instead of the enum value string This localizes the value displayed for the Override level setting found in the ASS Subtitles section on the Subtitle tab in IINA's settings.
|
One issue I did not address is that the text field holding the label is being sent to translators even though that value will never be used. Run this command to see the translations: I did not find a way in Xcode to exclude this text field from localization. Did I miss something? Because Crowdin is not able to read an XIB file as discussed in #4468 we have to use the English strings file. Would deleting the entry for the object ID Searching the net I found people using various methods, for example a reply to the stack overflow post Marking some XIB/Storyboard strings as not localizable suggests using as special phrase in the We might want to have some sort of |
|
@uiryuu Don't forget about my question as to how we should deal with objects that should not be sent to translators. |
|
@low-batt Sorry, I didn't read the thread.
I don't think there's a way to do so. I believe I have also did some research on this without success.
I'll test this, and try to find a way to do this semiautomatically with the Localizer Hint. |
- Remove strings like "Box", "Text Cell" which will not displayed in the UI - Remove Chrome and Firefox in the localization - Remove "strip" in `PrefSubViewController`, which will be replaced in in UI in runtime (#4893) - Added `NSHumanReadableCopyright` in `InfoPlist.strings`
* Remove unused strings (don't translate) - Remove strings like "Box", "Text Cell" which will not displayed in the UI - Remove Chrome and Firefox in the localization - Remove "strip" in `PrefSubViewController`, which will be replaced in in UI in runtime (#4893) - Added `NSHumanReadableCopyright` in `InfoPlist.strings` * Added back Chrome and Firefox for localization
This commit will:
Localizable.stringsfilestransformedValuemethod in theASSOverrideLevelTransformerclass to return a localized string instead of the enum value stringThis localizes the value displayed for the Override level setting found in the ASS Subtitles section on the Subtitle tab in IINA's settings.
Description: