Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL language causes button to overlap scroll bar #4910

Open
1 task done
low-batt opened this issue May 4, 2024 · 1 comment
Open
1 task done

RTL language causes button to overlap scroll bar #4910

low-batt opened this issue May 4, 2024 · 1 comment

Comments

@low-batt
Copy link
Contributor

low-batt commented May 4, 2024

System and IINA version:

Expected behavior:
Controls do not overlap scroll bars.

Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language and open the settings window then the red window button overlaps the scroll bar as seen here:
window-button-overlap

The window buttons should have moved to the right side of the window. The menu bar also did not flip. If instead the language is set to Right-to-Left Pseudolanguage the window buttons are correctly flipped:
right-to-left

As seen in this comment the window buttons are also not flipped with Safari. The Hebrew language must be set for the entire system for the window buttons to correctly flip. And yet it macOS is clearly able to flip the window buttons for an individual app since it does so for Right-to-Left Pseudolanguage. This seems like a macOS defect.

@ShlomoCode suggests moving the scroll bar as seen in this comment to avoid the overlap.

Steps to reproduce:

  • Pull PR feat: enable hebrew locale #4922

  • Open the IINA project in Xcode

  • Under the Product menu open the Scheme menu and select Edit Scheme…

  • Click on the Options tab

  • Scroll down to the App Language setting

  • In the pull down select Hebrew

  • Start IINA running under Xcode

  • Click on Settings… under the IINA menu

  • The settings panel appears

  • Notice the red window button on the left side of the window overlaps the scroll bar

  • MPV does not have this problem.

mpv does not support localization.

How often does this happen?
Every time.

@ShlomoCode
Copy link

ShlomoCode commented May 5, 2024

The problem of the location of the buttons in the scenario of English system language and Hebrew application language, also causes a problem with float on top button position:
CleanShot 2024-05-05 at 04 58 59@2x
I write it here because it seems to me to come from the same source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants