Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplayGain support #4915

Open
MrSimmo opened this issue May 5, 2024 · 5 comments · May be fixed by #4932
Open

ReplayGain support #4915

MrSimmo opened this issue May 5, 2024 · 5 comments · May be fixed by #4932
Assignees
@low-batt
Labels
feature: preferences progress: pr ready type: feature request

Comments

@MrSimmo
Copy link

MrSimmo commented May 5, 2024

What you want IINA to do:

Would be great to be able to add ReplayGain support natively to the UI (I know we can set values using MPV advanced settings but it would be nice to be able to set and alter ReplayGain settings in the audio settings).

Why you think this should be added:

It would allow libraries of music which have ReplayGain tags added to music files to be able to be played at the intended gain levels.

Examples of other projects that have something similar:

Foobar2000 Mac has an excellent ReplayGain implementation, with clipping support etc. Note, I'm not suggesting Iina supports creation of ReplayGain tags, only reading and using existing tags.
@low-batt
Copy link
Contributor

low-batt commented May 5, 2024

Really nice writeup of the requested feature.

The request is to add UI support for the mpv replaygain option:

--replaygain=<no|track|album>
Adjust volume gain according to replaygain values stored in the file metadata. With --replaygain=no (the default), perform no adjustment. With --replaygain=track, apply track gain. With --replaygain=album, apply album gain if present and fall back to track gain otherwise.

I'm assuming it is desirable to also include support for the associated options:

@low-batt low-batt self-assigned this May 15, 2024
low-batt added a commit that referenced this issue May 19, 2024
@low-batt
Close ReplayGain support, #4915
3bbf278 
This commit will:
- Add new the settings replayGain, replayGainPreamp, replayGainClip and
  replayGainFallback to the Preferences class
- Add support for the new settings to the mpvInit method in the
  MPVController class
- Add a ReplayGain section to the Video/Audio tab of IINA's settings

These changes allow the user to control mpv's support for ReplayGain
tags.
@low-batt low-batt linked a pull request May 19, 2024 that will close this issue
Open
2 tasks
@low-batt low-batt linked a pull request May 19, 2024 that will close this issue
Close ReplayGain support, #4915 #4932
Open
2 tasks
@low-batt
Copy link
Contributor

Please have a look at the screenshots of the proposed implementation in PR #4932. Does that look like what you were expecting? Does the mpv behavior I show look like ReplayGain is working?

@MrSimmo
Copy link
Author

MrSimmo commented May 20, 2024

Please have a look at the screenshots of the proposed implementation in PR #4932. Does that look like what you were expecting? Does the mpv behavior I show look like ReplayGain is working?

This is brilliant - looks great! Yup, looks like its working fine. Thank you again

@low-batt
Copy link
Contributor

Very helpful that you entered this issue. I was unaware of this mpv feature.

I'm a junior IINA developer so the proposed changes still need to be reviewed by the other developers. Future release plans are always subject to change, but last I heard the next release will be a bug fix release, so unlikely this change will make it into that release. As soon as possible after that release will be the first beta release for the long planned feature release. I'm expecting this change will make it into that release.

@MrSimmo
Copy link
Author

MrSimmo commented May 21, 2024

Thanks low-batt; sounds good! and thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
feature: preferences progress: pr ready type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close ReplayGain support, #4915 iina/iina
2 participants
@MrSimmo @low-batt