Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't disable pause when machine goes to sleep #4917

Open
1 task done
low-batt opened this issue May 5, 2024 · 1 comment · Fixed by #4918
Open
1 task done

Can't disable pause when machine goes to sleep #4917

low-batt opened this issue May 5, 2024 · 1 comment · Fixed by #4918

Comments

@low-batt
Copy link
Contributor

low-batt commented May 5, 2024

System and IINA version:

  • macOS 13.6.3
  • IINA 1.3.4

Expected behavior:
Unchecking a checkbox for a setting disables the setting.

Actual behavior:
Unchecking the Pause when machine goes to sleep setting does not change the setting. If you restart IINA the setting will show as checked. If on a MacBook you close the lid and then open it playback will remain paused.

Steps to reproduce:

  • Start IINA

  • Click on Settings… under the IINA menu

  • The settings panel appears

  • In the Behavior section click on the Pause/resume when disclosure triangle

  • Uncheck the Pause when machine goes to sleep

  • Restart IINA

  • Click on Settings… under the IINA menu

  • In the Behavior section click on the Pause/resume when disclosure triangle

  • Notice the Pause when machine goes to sleep is back to being enabled (checked)

  • MPV does not have this problem.

This is an IINA setting.

How often does this happen?
Every time.

@low-batt low-batt self-assigned this May 5, 2024
low-batt added a commit that referenced this issue May 5, 2024
This commit will add to PrefGeneralViewController.xib the missing
binding from the "Pause when machine goes to sleep" checkbox to the
pauseWhenGoesToSleep user defaults value.
@low-batt low-batt linked a pull request May 5, 2024 that will close this issue
2 tasks
svobs pushed a commit to svobs/iina-advance that referenced this issue May 6, 2024
This commit will add to PrefGeneralViewController.xib the missing
binding from the "Pause when machine goes to sleep" checkbox to the
pauseWhenGoesToSleep user defaults value.
uiryuu pushed a commit that referenced this issue May 22, 2024
This commit will add to PrefGeneralViewController.xib the missing
binding from the "Pause when machine goes to sleep" checkbox to the
pauseWhenGoesToSleep user defaults value.
@low-batt
Copy link
Contributor Author

The fix for this issue has been merged into the IINA develop branch. I am reopening this issue until the fix is available in an official release of IINA so that users intending to report this problem can easily locate this existing report. Once the fix for this issue has been included in an official release this issue will be closed.

@low-batt low-batt reopened this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant