Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL language causes misalignment of equalizer label #4923

Open
1 task done
low-batt opened this issue May 9, 2024 · 0 comments · Fixed by #4924
Open
1 task done

RTL language causes misalignment of equalizer label #4923

low-batt opened this issue May 9, 2024 · 0 comments · Fixed by #4924

Comments

@low-batt
Copy link
Contributor

low-batt commented May 9, 2024

System and IINA version:

Expected behavior:
The text fields under the sliders in the Equalizer section on the AUDIO tab of the quick settings panel are properly aligned with slider they are intended to label.

Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then show the audio panel the 31.25 label is severely miss-aligned:
equalizer

Steps to reproduce:

  • Pull PR feat: enable hebrew locale #4922

  • Open the IINA project in Xcode

  • Under the Product menu open the Scheme menu and select Edit Scheme…

  • Click on the Options tab

  • Scroll down to the App Language setting

  • In the pull down select Hebrew

  • Start IINA running under Xcode

  • Start playing a video

  • Press ⇧⌘A to show the audio panel

  • Notice the 31.25 label under the sliders in the Equalizer section is miss-aligned

  • MPV does not have this problem.

mpv does not support localization.

How often does this happen?
Every time.

@low-batt low-batt self-assigned this May 9, 2024
low-batt added a commit that referenced this issue May 9, 2024
This commit will correct the centerX constraint for the 31.25 label.
@low-batt low-batt linked a pull request May 9, 2024 that will close this issue
2 tasks
uiryuu pushed a commit that referenced this issue May 24, 2024
This commit will correct the centerX constraint for the 31.25 label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant